search

aergoio / aergo

aergo blockchain kernel
http://docs.aergo.io
MIT License
214 stars 45 forks source link

refactoring for fee calc logic #310

Closed rabbitprincess closed 12 months ago

rabbitprincess commented 1 year ago

What is changed?

refactoring fee calculation logic to fee package add unit tests for fee logic

( tx total fee = tx base fee + tx execute fee )

Is there risk of fork?

yes. it need to sync test.

kroggen commented 1 year ago

Why the sync test was started before the review? It is not approved

rabbitprincess commented 1 year ago

Why the sync test was started before the review? It is not approved

it is my mistake. ( communicate with kyungsub ) i will start sync test after approved.

kslee8282 commented 1 year ago

start sync mainnet Nov 8 05:46:22.135 INF ../go/aergo/cmd/aergosvr/aergosvr.go:100 > AERGO SVR STARTED branch=feature/refactor-fee module=asvr revision=2b8e2b75

kslee8282 commented 12 months ago

sync success