refactor state

[rabbitprincess]

What is changed?

remove unnecessary value copy using reflect rename state.V to state.AccountState change to all account balance modify logic must use AccountState separate statedb from state ( it related with experiment/evm_state_wip )

Is there risk of fork?

yes. it need to sync test.

[kroggen]

It appears that state/storage.go was moved to state/statedb/storage.go But it does not appear as a move in the diff

[kroggen]

Wow, you made a lot of changes here It took me more than 1 hour to review it It appears mostly OK Let's see the result of sync test

[kslee8282]

start sync mainnet Nov 27 05:17:20.608 INF ../go/aergo/cmd/aergosvr/aergosvr.go:98 > AERGO SVR STARTED branch=feature/refactor-state module=asvr revision=8f4e472c

[kslee8282]

sync success

[kroggen]

Oh wait, you did not answer the question I wrote above @gokch

[rabbitprincess]

Oh wait, you did not answer the question I wrote above @gokch

which question? it seems all resolved.

[kroggen]

There are 2 open.One about the removal of a nil check. Do they not appear to you?

[rabbitprincess]

There are 2 open.One about the removal of a nil check. Do they not appear to you?

this issue seems answered. are they having additional problem not solved?

[kroggen]

This is how it appears to me:

No answer

[rabbitprincess]

i answered this issue. it is no problem

[kroggen]

It is marked as pending. This is why it does not appear to others, only to you

But OK, I saw your answers on the image. This can be merged

[kroggen]

Maybe you clicked on "Start Review". Then all the comments are marked as "pending" until your review is finished