enable `minted` package for code highlighting

aergus / dockerfiles

Creative Commons Zero v1.0 Universal

19 stars 38 forks source link

enable `minted` package for code highlighting #1

Closed akolotov closed 6 years ago

akolotov commented 6 years ago

influenced by the idea from https://github.com/vvhof/minted-latex-docker to add minted package to the image.

I have tested the changes:

by publishing the image: docker pull akolotov/latex
by including the image into https://gitlab.com/project-oriented-challenges/onti-irs-201718-assignements/blob/master/.gitlab-ci.yml

aergus commented 6 years ago

Hi, thanks for the pull request. I'm sorry that I'm so late -- I don't check my GitHub account very often.

Enabling minted sounds like a good idea in principle, but I'd like to keep the list of installed packages as simple as possible, so here are a few thoughts I had regarding your changes:

texlive-latex-extra is a dependency of texlive-full, so do we really need to install it manually?
Why is python-pip required?
python is a dependency of python-pygments, so do we really need to install it manually?

akolotov commented 6 years ago

Thanks, @aergus for response. In fact I did not experimented with the set of installed packages just took them as is from https://github.com/vvhof/minted-latex-docker. So, the answers for your questions is more my opinion rather than strict arguments.

the first and third bullets - probably they are listed there for easy further support by meaning 'doing something directly rather to indirectly to expose possible issues with dependencies in the future'
the second bullet - not 100% sure but probably it is required to resolve possible dependencies during python-pygments installation. Unfortunately I have no logs produced when akolotov/latex image prepared to find proofs there.

aergus commented 6 years ago

I guess that this would work just as fine if one only adds python-pygments to the list. I have tested it with a minimal example (the first example here), and it seems to work.

Thus I stand by my point of keeping the list of packages which are installed as simple as possible and leaving dependency issues to Debian maintainers (i.e. I'd rather assume that texlive-full will actually install all TeXLive packages and that pygments will work out of the box after installing python-pygments than keep track of more packages).

I've merged your changes manually with the above mentioned simplification. Thanks again for bringing this up.