search

aeris / cryptcheck

Verify some SSL/TLS website or XMPP implementation
GNU Affero General Public License v3.0
185 stars 20 forks source link

Fix Docker build for ruby 2.3.x #51

Closed HLFH closed 4 years ago

HLFH commented 4 years ago

The openssl link needs to be updated as seen here: https://www.openssl.org/source/ And because cryptcheck requires openssl 1.0.x as seen here: https://github.com/aeris/cryptcheck/issues/46#issuecomment-533865220

Also simplecov and pry-byebug need to be adjusted to work for ruby 2.3.x.

Otherwise the command docker build . won't work.

aeris commented 4 years ago

I try without version pinning for dependencies and it seems to work :thinking:

HLFH commented 4 years ago

I have errors on macOS Catalina 10.5.5 with docker build . as cryptcheck is using ruby 2.3.x. With no pinning, in my case, it wants to install the latest version of pry-byebug and simplecov which are requiring to have ruby >= 2.4. That's why for these gems, I am pinning to the latest version that supports ruby 2.3.x.

HLFH commented 4 years ago

As stated in the Docker documentation:

IPv6 networking is only supported on Docker daemons running on Linux hosts. Docker for Mac does not support IPv6 networking.

While on Mac, it was necessary to do version pinning for pry-byebug and simplecov, I consider at the time, Docker for Linux should be used.

So I migrated from Docker on Mac platform to Docker on ArchLinux. Afterwards, I reset the version pinning commits that were unnecessary on Linux, and I force-pushed.

Can you merge?

Thanks, HLFH

aeris commented 4 years ago

Sure :+1: I'm currently working on a huge rework to try supporting TLSv1.3 with a dual stacked Ruby (2.3 & 2.6). pry-byebug & others will be addressed on the same time.