book = epub.read_epub('test.epub', options={'ignore_ncx': False})
will raise a user warning because the current logic checks for Falsey-ness rather than None. The expected behaviour is that no warning should be raised as the option was passed explicitly (the warning about the default value doesn't matter). This pull request changes the deprecation check to check for None rather than falsey-ness.
aerkalov
commented
2 months ago
Check for None rather than falsey-ness.
The current problem is that
will raise a user warning because the current logic checks for Falsey-ness rather than None. The expected behaviour is that no warning should be raised as the option was passed explicitly (the warning about the default value doesn't matter). This pull request changes the deprecation check to check for None rather than falsey-ness.