search

aerleon / aerleon

Multi-platform ACL generation system
https://aerleon.readthedocs.io/
Apache License 2.0
194 stars 32 forks source link

add generated/changed timestamp for generated filters - instead of repository tags #203

Open fischa opened 1 year ago

fischa commented 1 year ago

When looking back - the repository tags that cannot be used with git are mostly useless to many. A more useful indicator could be a time stamp of the generation time (in case a filter is actually changing). E.g. 2022-01-18T17:45:00+00:00 and make that format configurable but defaulting to ISO8601 with UTC as timezone.

For example:

! generated: 2022-01-18T17:45:00+00:00
no ip access-list <access-list-name>
 remark generated 2022-01-18T17:45:00+00:00
...

or

firewall {
    family inet {
        /*
         ** generated: 2022-01-18T17:45:00+00:00
         */
        replace: filter <filter-name> {

With that there would be clear indicator pointing to the date+time the filter was build. Thoughts?

ankenyr commented 1 year ago

Actually I believe they can be used in git. Check out https://github.com/aerleon/aerleon/issues/117 You use git attributes with a smudge and clean step. We want to add this as an example in our repository so people can see it in use and have all of our policies versioned.