search

aerni / statamic-advanced-seo

Comprehensive SEO addon for Statamic with flexibility in mind
https://statamic.com/addons/aerni/advanced-seo
10 stars 5 forks source link

Runway support #154

Closed lukevmk closed 1 day ago

lukevmk commented 2 days ago

Currently the SitemapIndex supports Collections and Taxonomies.

For a project we use Runway (https://runway.duncanmcclean.com) (https://statamic.com/addons/rad-pack/runway) a first party Statamic package. That makes it possible to manage Eloquent models in the Statamic interface and more.

Are you open for a pull request to support Runway?

aerni commented 2 days ago

I don't think I understand your request. I'm not sure what Runway has to do with the SitemapIndex supporting Collections and Taxonomies?

lukevmk commented 2 days ago

The SitemapIndex supporting the Collections and Taxonomies was just an example and proof that my idea could work.

Our use case is a website for a travel agency. Everything is packed in Statamic as you would expect. But the website also has a ton of accommodations that it has to manage and show (over 4.000). So we decided to place them in the database, since Statamic performs really badly with large collections.

That is where Runway came into play. Runway made it possible to manage the database model of the accommodations in the Statamic interface like a normal entry.

The last hurdle we have to take is SEO. We use your SEO package for all of our websites, but it does not work with Runway (yet). I suggested to make the Runway models work like you made it for the Collections and Taxonomies.

aerni commented 1 day ago

I understand. I'm not familiar with Runway. Are the sitemaps the only Advanced SEO feature that doesn't work with Runway? Everything else in the SEO tab works as expected?

I'm generally open to a PR. But given how tightly integrated the sitemaps are with Statamic's collections and taxonomies, I'm not sure of the implications of adding support for Runway models. Maybe a different sitemap driver for Runway would make more sense. Again, I don't know. If you can whip up a PR to show the general direction, that would be helpful.

lukevmk commented 1 day ago

Noo, the other stuff does not work either, but I got a work around for that.

The sitemap was to much work to create myself. That is why I am trying this way :)

Okay! I will send in a PR with a general direction and let's see from there. I think Runway support could be a really nice add-on for you package!

aerni commented 1 day ago

Ok, I hear you. I'd rather add full support for Runway than just partial support for sitemaps. But again, I have no idea about the implications of this.

You said that you found a workaround for the other stuff that doesn't work. Have you tried using custom sitemaps as a workaround as well?