search

aerobicio / aerobic.io

Fitness tracking for friends
1 stars 1 forks source link

PROPOSAL: Only run consistency fail migration enforcing when in test env. #178

Closed plasticine closed 10 years ago

plasticine commented 10 years ago

This removes the consistency_fail enforcer when in development, making it only run when in test mode.

If I understand the intention of this tool correctly we will still get all the benefits of consistency_fail by only enforcing checks in the test env, and not have to deal with the inconvenience of having it in the development env.

I find it makes evaluating a WIP PR (where index are maybe not added yet) much more of a PITA, and given that we will never let a failing branch of code get into master it seems redundant anyway.

Thoughts?

quamen commented 10 years ago

Do it! This was pissing me off while writing migrations yesterday.