search

aerobicio / aerobic.io

Fitness tracking for friends
1 stars 1 forks source link

Rubocop #212

Closed quamen closed 10 years ago

quamen commented 10 years ago

You knew this was coming...

aww-yiss-owl

This PR adds rubocop to aerobic.io, right now everything is ignored in order to allow us to gradually fix things.

There is a rubocop-todo.yml that ignores all of the things. If you feel like fixing all of the things, uncomment something and run:

rake rubocop

I've started working my way through the 1000 odd style guide infractions it has found. I figure once rubocop-todo.yml is gone we can merge this and add it to the build server.

Closes #207

quamen commented 10 years ago

 Code Climate has analyzed this pull request.

plasticine commented 10 years ago

I’m on board. Are you planning to add this to a CI run? I’ve been thinking we should move these checks to run before actual tests — means that these things will get caught earlier and be more of a clear blocker to code passing/running. Treating the code as broken if there are violations...

Not sure if you wanted review of this yet — but once you’re happy with it then just merge away IMO.

plasticine commented 10 years ago

I've started working my way through the 1000 odd style guide infractions it has found. I figure once rubocop-todo.yml is gone we can merge this and add it to the build server.

I should have read better.

quamen commented 10 years ago

Ermagerd so close to being done now. Except on a train I cannot download all of things. So hard to figure out where the coverage drop has come from...

quamen commented 10 years ago

Rubocop is now part of the build, it runs up front right after consistency_fail and before rails_best_practices to ensure we fail fast on basic stuff.

Cane needs to run after the test suite has finished because it does coverage.