search

aerobicio / aerobic.io

Fitness tracking for friends
1 stars 1 forks source link

Add sport to workout #248

Closed quamen closed 10 years ago

quamen commented 10 years ago

This PR makes the sport attribute available to workouts.

Older workouts will not have this attribute, we could go back and add them in, but that's probably a job for another PR.

This PR will be about building the UI to display the type of workout performed. I suggest we start with RUNNING, CYCLING and SWIMMING and treat any other value as we currently do. So gracefully enhance new workouts with an icon and text that reads correctly:

  • You went for a run
  • Justin went for a swim
  • Gareth uploaded a bike ride
quamen commented 10 years ago

 Code Climate has analyzed this pull request.

quamen commented 10 years ago

If we want to, we can ship this, new workouts will start picking up sports and the titles will be updated. Old workouts will remain the same.

plasticine commented 10 years ago

:ship: