Remove following feature flip. It is now permanently on.

quamen commented 10 years ago

Does what it says on the tin. Removes everything to do with having the :following feature flip in place:

Remove the flip from SwitchBoard.
Remove the exclude_following scope from the Activity model.
Remove before filters on the follow and unfollow methods in the MembersController.
Remove render_404 from MembersController as it is no longer required.
Remove the code that short circuits the following_link_for_members and member_relationship_status_for_members in FollowingHelper.
member_activities in ViewControllers::Dashboard::Show returns all activities now instead of differentiating based on the flip.
Remove tests around when the feature is off.
Remove context blocks around around when the feature is on, it's now the default state.
Remove step definitions that are no longer used without the feature flip.
Remove @flip @on and @flip @off tags on features.

So that was actually quite a bit of code debt right there.

quamen commented 10 years ago

Code Climate has analyzed this pull request.

plasticine commented 10 years ago

Hell yeah! :ship:

aerobicio / aerobic.io