search

aerobicio / aerobic.io

Fitness tracking for friends
1 stars 1 forks source link

[WIP] Add Peek::Git #275

Closed plasticine closed 10 years ago

quamen commented 10 years ago

 Code Climate has analyzed this pull request.

quamen commented 10 years ago

What does Peek::Git actually do?

plasticine commented 10 years ago

Adds a git ref and branch name item to Peek. Thought it might be rather useful for Beta to know what is running there.

quamen commented 10 years ago

ok cool :+1:

Might look a bit shit on a phone though as it won't all fit given the narrow width.

quamen commented 10 years ago

screen shot 2014-05-05 at 7 54 56 pm

So on mobile this looks like balls. Maybe we should only make it visible when it will fit properly?

quamen commented 10 years ago

@plasticine I've just pushed a commit that hides peek on anything other than a desktop display. This way it won't interfere with the navigation and will fit on the screen.

If you're happy with that feel free to merge this PR. Otherwise revert the commit and have a play with some styling.

plasticine commented 10 years ago

Not at a computer but that sounds good IMO. Merge away if you like.

On Mon, May 5, 2014 at 8:00 PM, Gareth Townsend notifications@github.com wrote:

@plasticine I've just pushed a commit that hides peek on anything other than a desktop display. This way it won't interfere with the navigation and will fit on the screen.

If you're happy with that feel free to merge this PR. Otherwise revert the commit and have a play with some styling.

Reply to this email directly or view it on GitHub: https://github.com/aerobicio/aerobic.io/pull/275#issuecomment-42173832

quamen commented 10 years ago

kk shipping it.