search

aerobicio / tcx

Ruby gem for reading Garmin TCX files
MIT License
2 stars 0 forks source link

Parse active duration and distance #2

Closed quamen closed 10 years ago

quamen commented 10 years ago

Throwing this up into a PR for testing.

I'm not sure if the active_duration or end_time attributes are getting the correct values. One of them is probably wrong so it would be nice if @plasticine could test this out locally with a TCX file that you know the real values of and let me know how you go.

I'm going to do the same by downloading some files from garmin connect to play with later.

plasticine commented 10 years ago

Sicko, nice work. Will have a geez and run some files past it.

plasticine commented 10 years ago

OK, so I think the numbers are right, but at the moment I’m testing old files. Going to go for a run today, note time/distance exactly and then re-test. I think it is pulling out active duration.

But tentative green light—looking good so far. :+1:

plasticine commented 10 years ago

@quamen Any reason for this not to be merged?

quamen commented 10 years ago

Nope. If we're happy with the numbers then merge away.