aerogear-attic / keycloak-operator

operates keycloaks
4 stars 2 forks source link

User reconciliation #21

Closed dimitraz closed 6 years ago

dimitraz commented 6 years ago

Description

Verification Verify that the above scenarios behave as expected

To do

mikenairn commented 6 years ago

Tested it locally and it does work, although i am seeing issues that i hit as well when doing https://github.com/aerogear/keycloak-operator/pull/23. In particular the use of "omitempty" on all fields is causing some issues.

Also looks like you need to do something similar to what i did here in order to update the spec object with the server side generated user id https://github.com/aerogear/keycloak-operator/pull/23/commits/9093a7838b6eeba277460c02f8382f024648ecaf

dimitraz commented 6 years ago

@mikenairn Updated, can you take another look? I've kept the update function because I think it works nicely and it performs the merge of kc and spec (including booleans) as expected