search

aerogear-attic / keycloak-operator

operates keycloaks
4 stars 2 forks source link

adding keycloak realm crd #41

Closed philbrookes closed 6 years ago

philbrookes commented 6 years ago

Motivation

https://trello.com/c/Cyp2anQA/198-5-add-basic-installation-operator-for-rh-sso

What

Allow Realms to be provisioned seperate to keycloak instances

Why

So that users that cannot provision keycloak can still use a realm in keycloak

How

Keycloak and Keycloak realms were split into separate CRDs and reconciled seperately

Verification Steps

Provision a cluster from: https://github.com/integr8ly/installation/pull/123

You should be able to login to the cluster using: admin@example.com / Password1 You should be able to login to 3scale using: evals01@example.com / Password1

Checklist:

Progress

maleck13 commented 6 years ago

@philbrookes 👀

maleck13 commented 6 years ago

I think it would make sense to use the same approach across each operator

Craig

On 12 Nov 2018, at 10:51, philbrookes notifications@github.com wrote:

@philbrookes commented on this pull request.

In pkg/keycloak/realm/fake/keycloakClient.go:

@@ -0,0 +1,93 @@ +package fake no, as I had already started, I decided to just get this finished. Do you think it is worth refactoring these tests to use moq?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

philbrookes commented 6 years ago

Verification: