aerogear-attic / minishift-mobilecore-addon

Addon for minishift to enable the Mobile Core
6 stars 13 forks source link

latest version of minishift has removed the --service-catalog flag #22

Open david-martin opened 6 years ago

david-martin commented 6 years ago

from @secondsun

Details https://github.com/minishift/minishift/pull/2241 and https://github.com/openshift/origin/pull/19209

There's some work to do to update our docs because it also looks like the oc cluster up --service-catalog has been replaced with --enable service-catalog as well.

I think we can just update the docs for the minishift plugin to instead of saying --service-catalog use --extra-clusterup-flags "--enable service-catalog", but I'm having trouble getting it working.

david-martin commented 6 years ago

With minishift v1.15.1+a5c47dd, this command is still OK

minishift start --openshift-version v3.9.0 --service-catalog

With minishift v1.16.0+8abe845, this command fails

minishift start --openshift-version v3.9.0 --service-catalog
...
unknown flag: --service-catalog

As does this command fail:

$ minishift start --openshift-version 3.9.0 --extra-clusterup-flags "--service-catalog"
-- Starting profile 'minishift'
-- Checking if https://github.com is reachable (using proxy: "No") ... OK
-- Checking if requested OpenShift version 'v3.9.0' is valid ... OK
-- Checking if requested OpenShift version 'v3.9.0' is supported ... OK
-- Checking if requested hypervisor 'kvm' is supported on this platform ... OK
-- Checking if KVM driver is installed ... 
   Driver is available at /usr/local/bin/docker-machine-driver-kvm ... 
   Checking driver binary is executable ... OK
-- Checking if Libvirt is installed ... OK
-- Checking if Libvirt default network is present ... OK
-- Checking if Libvirt default network is active ... OK
-- Checking the ISO URL ... OK
-- Checking if provided oc flags are supported ... Flag 'extra-clusterup-flags' is not supported for oc version v3.9.0. Use 'openshift-version' flag to select a different version of OpenShift.
FAIL

So, as we want to stick with 3.9.0 at the moment, and do want the service catalog, I think we have to mandate minishift < 1.16.0

@maleck13 thoughts

eriknelson commented 6 years ago

@david-martin @maleck13 this just caught us by surprise as well. I'm not sure there is a workaround unless minishift 15.1 is used, as you mentioned. Will try to keep you guys posted.

evanshortiss commented 6 years ago

@david-martin @eriknelson are you setting MINISHIFT_ENABLE_EXPERIMENTAL flag? Seems to work for me.

eriknelson commented 6 years ago

@evanshortiss @david-martin Meant to follow up, asked around with the minishift guys and it's moved to an extra-clusterup-flag option: https://docs.openshift.org/latest/minishift/using/experimental-features.html#enabling-experimental-oc-flags

The distinct --service-catalog flag is definitely gone as of v1.16.0.

Here's the updated ASB minishift addon PR I'm trying to get merged: https://github.com/minishift/minishift-addons/pull/113