aerogear / aerogear-digger-installer

Ansible role for installing AeroGear Digger on OpenShift
https://aerogear.org/
Apache License 2.0
4 stars 17 forks source link

Don't delete characters in password #4

Closed aidenkeating closed 7 years ago

aidenkeating commented 7 years ago

Currently we are using tr to remove the JENKINS_PASSWORD= section from our oc & grep result. However tr's functionality is as follows.

echo "aabbccdd" | tr -d b # Returns aaccdd

So we may delete characters in a password if they contain any of the characters included in JENKINS_PASSWORD=.

This uses awk instead.

aidenkeating commented 7 years ago

@laurafitzgerald @PhilipGough Would you mind taking a look?

philipgough commented 7 years ago

Looks good

aidenkeating commented 7 years ago

@PhilipGough Would you mind approving? It's a merge prerequisite