search

aerogear / aerogear-digger-installer

Ansible role for installing AeroGear Digger on OpenShift
https://aerogear.org/
Apache License 2.0
4 stars 17 forks source link

use status.availableReplicas for poll #55

Closed laurafitzgerald closed 7 years ago

laurafitzgerald commented 7 years ago

What Use .status.availableRecplicas in poll for pod check

Why .status.conditions... is was not used in OpenShift 3.3 deployment configs

Verification This change needs to be tested against cluster running both 3.3 and 3.5

Command to Run:

ansible-playbook -i ../rhmap-ansible/inventories/engineering/osm1/osm1-hosts sample-build-playbook.yml --skip-tags=osx-provision -e "project_name=digger-poll-14" --ask-vault-pass

Monitor the output and see that the poll will wait for the pods to come up in all cases (nagios, jenkins, android-sdk) on both versions (3.3 and 3.5)

wei-lee commented 7 years ago

@laurafitzgerald what's .status.availableRecplicas means? Is it safe to use it as the indicator that the pods are ready?

laurafitzgerald commented 7 years ago

@wei-lee see docs on this variable for 3.5 and 3.3

wei-lee commented 7 years ago

Verified on OSM1. Given that OpenShift APIs are backward compatible, I think this change is good.