search

aerogear / aerogear-digger-installer

Ansible role for installing AeroGear Digger on OpenShift
https://aerogear.org/
Apache License 2.0
4 stars 17 forks source link

add prompt for android sdk licence and download #96

Closed StephenCoady closed 7 years ago

StephenCoady commented 7 years ago

JIRA https://issues.jboss.org/browse/AGDIGGER-204

Changes A prompt for the android sdk licence and download has been added.

StephenCoady commented 7 years ago

Verification steps:

Run the installer. The user should be prompted to visit a link to the licence and if they accept they should press enter.

odra commented 7 years ago

👀

odra commented 7 years ago

Executing this inside the android sdk pod works: test -f {{ android_sdk_home }}/tools/bin/sdkmanager

Then changing the when condition to check the shell command exit code ("rc" property) works

StephenCoady commented 7 years ago

the only trouble with doing it this way is that when it doesn't exist (i.e when the project has just been set up) then it will fail and cause anything that uses the output to be skipped when ignore_errors is used

StephenCoady commented 7 years ago

@odra sorry, now ignore my previous comment. I had my logic wrong. Although now we get a big red warning on the first time we run the playbook saying the test command has failed. Is this ideal?

StephenCoady commented 7 years ago

apologies for the spam, I missed your offline comment to use failed_when: false. this got around an error showing. I have updated the code now and it should be working