aerogear / charmil

The framework for building modular plugin based CLI's using Cobra and Golang
https://aerogear.github.io/charmil
Apache License 2.0
116 stars 13 forks source link

fix(core): improve config management package #233

Closed namit-chandwani closed 3 years ago

namit-chandwani commented 3 years ago

WIP (Up for an early discussion)

Closes #184

Description

Type of change

Checklist

wtrocki commented 3 years ago

@namit-chandwani I do not see how this would work.

Approach with subkeys is not going to allow us to load and write structure. Please look at example plugin and example host. Modify them to use different configs and we can discuss later hoe to swap the config from host. Proposed PR doesn't differ much with config on main branch that we covered over last call.

wtrocki commented 3 years ago

Ignore comments. Lets work with @ankithans to help him with examples and solve config outside core first