Description

The init command of Charmil CLI uses the template files and their placeholders that are currently present in the charmil-starter repo to generate a starter project, which makes the charmil-starter repo unusable without the init command (ie. users cannot clone the repo and use it directly due to the presence of template files).
Our aim is to provide an additional option for users to use Charmil Starter by allowing them to directly clone the charmil-starter Github repository.
This can be achieved by following these 2 steps:
- Change the init command implementation to replace default values with the user-specified ones (ie. Github org/user name, repo name and CLI name) by performing simple String replacements instead of using go templates and substituting its placeholders. [Handled by this PR]
- Remove the current contents of the charmil-starter repo (as it contains template files instead of runnable code) and replace it with the contents of the starter present in this repo (charmil/starter). [Handled by the PR: aerogear/charmil-starter/pull/7]

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation change
[ ] Other (please specify)

namit-chandwani commented 3 years ago

This PR is now ready for review :)

CC: @wtrocki

wtrocki commented 3 years ago

ETA 1 day. Weekend

wtrocki commented 3 years ago

I do not think all uses of cli name were properly replaced :)

namit-chandwani commented 3 years ago

good stuff but left some suggestions

Sorry, missed the notification somehow. Will make the required changes tomorrow :)

namit-chandwani commented 3 years ago

Merging this PR now and making a new Charmil release for both charmil/starter module and charmil-starter repo to use.