search

aerogear / graphback

Graphback - Out of the box GraphQL server and client
https://graphback.dev
Apache License 2.0
409 stars 73 forks source link

Add categories to templates - community, external etc. #2086

Open wtrocki opened 4 years ago

wtrocki commented 4 years ago

Is your feature request related to a problem? Please describe. Please describe the problem you are trying to solve.

Describe the solution you'd like Please describe the desired behavior.

Describe alternatives you've considered Please describe alternative solutions or features you have considered.

machi1990 commented 4 years ago

/cc @craicoverflow, @machi1990 Automatically generated comment to notify maintainers

wtrocki commented 4 years ago

More context here. We will be working with partners to try out their work and we need a way to include their templates into graphback for recognition and also association with technologies we cannot or have time to investigate.

craicoverflow commented 4 years ago

Would the templates live in the repo, or will they be pulled from multiple sources, so that they do not all need to live inside the repo?

wtrocki commented 4 years ago

Never in the repo. Entire concept will be to have them as community ones that might get outdated etc. after a while. This is one of the strategies that we will cover to promote graphback - it actually requires technical investment because I would not expect creator to add this capability (separate sort for community ones) - just add link to repo and that will be it.

machi1990 commented 4 years ago

Never in the repo. Entire concept will be to have them as community ones that might get outdated etc. after a while. This is one of the strategies that we will cover to promote graphback - it actually requires technical investment because I would not expect creator to add this capability (separate sort for community ones) - just add link to repo and that will be it.

We already have the ability to indicate template's url https://github.com/aerogear/graphback/blob/375dc5105455a4ee5c29c5db70634c7cdc693443/packages/create-graphback/src/index.ts#L28

If I understood correctly, the use case here is to be able to indicate that an template is a community provided or an external template if the url does not match graphback's templates repository?

craicoverflow commented 4 years ago

IIRC that flag does not work.

https://github.com/aerogear/graphback/issues/1043 not sure why we closed this

wtrocki commented 4 years ago

Ah.. idea here is to actually embedd them into some separate json file that people can edit and list them on init (but with header - those are community maintained). So people can get something they feel familiar with.

machi1990 commented 4 years ago

Ah.. idea here is to actually embedd them into some separate json file that people can edit and list them on init (but with header - those are community maintained). So people can get something they feel familiar with.

Even better.

RinkiyaKeDad commented 4 years ago

Hi! Can I work on this? As far as I understand the goal is that people should be able to provide a link to their template (a JSON file) by using something like: graphback init --templateUrl=<link-goes-here>? What would be a good starting point for solving this? Thanks.

wtrocki commented 4 years ago

I was thinking we can actually create templates.json file in repo where community can add their templates. Graphback-cli project have them hard coded for the moment so we can split between community and base templatez