search

aerogear / graphback

Graphback - Out of the box GraphQL server and client
https://graphback.dev
Apache License 2.0
409 stars 73 forks source link

Remove mixed test executors #641

Closed wtrocki closed 4 years ago

wtrocki commented 4 years ago

In some cases we are using jest and is some cases we are using ava

wtrocki commented 4 years ago

Our prefference will be to use jest

binayakbehera999 commented 4 years ago

Hello, @wtrocki I would like to work on this issue. Can we use the jest-code to migrate to jest?

wtrocki commented 4 years ago

Anyway to migrate will work for me. Minimize amout of work needed

wtrocki commented 4 years ago

@binayakbehera999 We are hitting some issues in relation to jest/ava and we have now a great time to migrate them. Do you still work on this?

kingsleyzissou commented 4 years ago

@wtrocki I can look at this if you want. Are you okay with doing it similarly to how offix is setup and run jest from the root?

wtrocki commented 4 years ago

@craicoverflow Any opinions on this? I guess having some form of standard across two repos is good.

kingsleyzissou commented 4 years ago

Just saw that @darahayes was doing something with Jest. Are you already working on this issue?

darahayes commented 4 years ago

I was looking into it but please feel free to take it 🙂

kingsleyzissou commented 4 years ago

No stress, haven't started yet. If you're already on it you may as well

craicoverflow commented 4 years ago

@craicoverflow Any opinions on this? I guess having some form of standard across two repos is good.

No strong opinions - what are the issues you speak of?

kingsleyzissou commented 4 years ago

Closed with PR #921