search

aerogear / graphql-link

graphql-link is a GraphQL server that composes other GraphQL or OpenAPI endpoints
https://aerogear.github.io/graphql-link
Other
38 stars 8 forks source link

Setup PR validation workflow using CircleCI #12

Closed chirino closed 4 years ago

chirino commented 4 years ago

Something like https://github.com/skupperproject/skupper-cli/blob/master/.circleci/config.yml would be handy.. Where it can also do the release builds when tags are created.

wtrocki commented 4 years ago

That is already done using github actions (they are faster than circleci)

machi1990 commented 4 years ago

That is already done using github actions (they are faster than circleci)

@wtrocki any pointers for the GH action?

wtrocki commented 4 years ago

Hi

All builds are here: https://github.com/chirino/graphql-gw/actions

Do you want to create GH actions on different project?

machi1990 commented 4 years ago

Hi

All builds are here: https://github.com/chirino/graphql-gw/actions

Do you want to create GH actions on different project?

The Circle CI workflow shared above seemed rich (like it can do a lot of things), was curious to see if there is already a GH action that does something similar: even though we can argue that it is mostly bash scripts and yaml files And possibly, see if I could add it in this project (to fix the issue).

wtrocki commented 4 years ago

My opinion:

GH action - fast reliable close to source easy to setup and extend. I haven't done any crazy stuff like starting kubernetes for tests.

CircleCI more suited for complex use cases. More docker friendly.

I started configuring GitHub ones as it is simply easier to build and manage. Linked config can be ported to GitHub actions but not sure if that will hit the limits of free quota

chirino commented 4 years ago

it's working. thx