search

aerogear / keycloak-connect-graphql

Add Keyloak Authentication and Authorization to your GraphQL server.
Apache License 2.0
157 stars 23 forks source link

chore: release 0.5.0 #86

Closed darahayes closed 4 years ago

darahayes commented 4 years ago

Needed to use the new helper function in the graphback/keycloak-authz package

wtrocki commented 4 years ago

Rule we have is that we are trying to update package dependencies of the package before release. I will approve it but if you do not mind closing other opened package updates PR before actual release

darahayes commented 4 years ago

@wtrocki that's a good point. I've merged the minor and patch dependency update PRs. There are two other PRs that introduce some major updates and he builds are failing on those. I think they will need some extra work to get them merged. Happy for us to do a release with the minor and patch updates and then we can create another release that integrates the major updates?

wtrocki commented 4 years ago

major ones are not needed. Unless you thinking about graphql-tools that is different. Ideally we should move to graphql tools but that might be difficult/different release

darahayes commented 4 years ago

It looks like the GraphQL tools one will require some refactoring so I'd like to see it done in a separate PR/release. Going to merge this one now to enable the graphback auth package

wtrocki commented 4 years ago

Yes.. This is important so maybe we can create issue. Very very strong dependency on graphql tools here will be always problem. We have now community graphql-tools and apollo-server diverging with people using different versions etc.

Let's create issue for this as it is something that we might link till GA.

Possible we can do: