aerogear / keycloak-metrics-spi

Adds a Metrics Endpoint to Keycloak
Apache License 2.0
549 stars 156 forks source link

Fix the dependency to work with Keycloak 16.0.0 #125

Closed jonathanvila closed 2 years ago

jonathanvila commented 2 years ago

Motivation

Add references to relevant tickets or a short description about what motivated you do it. (E.g JIRA: https://issues.jboss.org/browse/AEROGEAR-{} AND/OR ISSUE: https://github.com/aerogear/standards/issues/{})

124

What

Explicitly specify the RestEasy version that comes with Wildfly 25 instead of the one specified in Keycloak Changed the method to register the Filter

Why

RestEasy v4 has changed the API

How

Explicit specification of the resteasy dependency on the build.gradle Modified the way to register the filter

Verification Steps

Already present tests are still working Deployed Keycloak 16.0.0 with this new code and KC starts and the metrics endpoint responds with the metrics

Checklist:

Progress

Additional Notes

PS.: Add images and/or .gifs to illustrate what was changed if this pull request modifies the appearance/output of something presented to the users.

pb82 commented 2 years ago

@jonathanvila is this already covered by #120 ?

pb82 commented 2 years ago

@jonathanvila can you please check if release 2.5.3 works on Keycloak 16?

jonathanvila commented 2 years ago

@pb82 I have tested that with KC 16.1.0 and it works fine Thank you.