Add optional basic auth for pushgateway - Githubissues

aerogear / keycloak-metrics-spi

Adds a Metrics Endpoint to Keycloak

Apache License 2.0

523 stars 151 forks source link

Add optional basic auth for pushgateway #172

Closed hashworks closed 10 months ago

hashworks commented 11 months ago

Motivation

Resolves #145.

What

Allow users to provide username and password for basic auth protected pushgateways.

Why

Some pushgateways may require basic auth authentification.

How

https://github.com/prometheus/client_java/blob/main/integration_tests/it_pushgateway/src/main/java/io/prometheus/client/it/pushgateway/ExampleBatchJob.java#L32C13-L32C91

Verification Steps

A simple test has been added.

To test this completely:

Protect a pushgateway endpoint using basic auth
Set the required env variables
Start keycloak and verify metrics in pushgateway

Checklist:

[X] Code has been tested locally by PR requester
[ ] Changes have been successfully verified by another team member

pb82 commented 10 months ago

thanks @hashworks !