search

aerogear / keycloak-metrics-spi

Adds a Metrics Endpoint to Keycloak
Apache License 2.0
523 stars 151 forks source link

New updated metrics spi for Keycloak 24 #198

Open GSXswe opened 2 months ago

GSXswe commented 2 months ago

Description

Need new updated metrics spi with support for Keycloak 24.

Environment

doggy-dev commented 2 months ago

Does version 5.0.0 work with Keycloak v24?

GSXswe commented 2 months ago

After some testing it seems like the code does support v24, more testing is needed.

alplunge commented 2 months ago

Does it work or not really ? @cturkalj any news about this one ?

GSXswe commented 2 months ago

It works for us, we are getting metrics. :-)

alplunge commented 2 months ago

@GSXswe are you using tagged version 5.0? and simply included metrics as extension without any additional fiddling?

cturkalj commented 2 months ago

@alplunge , it works for me as well (the official 5.0.0 release version) without any additional fiddling

alplunge commented 2 months ago

@cturkalj I have one following question, is there any reason why only POM got updated with quarkus-resteasy-reactive for compatibility https://github.com/aerogear/keycloak-metrics-spi/commit/aede7e088692f88470b8e2cb22e2d4a70d9341fe ?

cturkalj commented 2 months ago

@alplunge: I am not sure I understand your question. The MetricsFilterProvider was updated for compatibility with Keycloak 23 (it needed to work with resteasy reactive for proper filter registration) .

alplunge commented 2 months ago

@cturkalj sorry for not being specific enough, shouldn't build.gradle be also be updated for gradle builds?

cturkalj commented 2 months ago

@alplunge: You're right, I didn't use gradle - I used maven. But I don't know the release process. I assume it uses maven (@pb82 probably knows). It doesn't matter if you use the released version, since it is a povided dependency. You should create a PR to update the gradle build file.

amasiero commented 3 weeks ago

@GSXswe, can you give me a direction here? I'm facing the same "issue" with the same version.