aerogear / keycloak-metrics-spi

Adds a Metrics Endpoint to Keycloak
Apache License 2.0
551 stars 156 forks source link

Remove route from response errors #66

Closed davidporos92 closed 4 years ago

davidporos92 commented 4 years ago

Motivation

The response_errors also included the route label, which can lead to a lots of data. This is pretty similar to #65

What

Removes the route from the response_errors. Also, I've updated the readme to align with the current responses.

Why

Avoid creating an excessive number of metrics.

Verification Steps

This part of the code is covered by test.

Checklist:

Progress

pb82 commented 4 years ago

good catch, thanks @davidporos92

Will verify and merge asap

pb82 commented 4 years ago

thanks again @davidporos92 !