Closed xinau closed 3 years ago
@xinau Why not use a selector that ignores the labels (or some of them) to build the sum?
@pb82 the problem with ignoring labels is that it's still not helpful as shown in the folliwng screenshot. the problem still remains. without filtering all labels their can still be a margin of error >40%.
this looks good @xinau Sorry for the delay, will add this to the next release
@pb82 thanks. :)
thanks @xinau
Motivation
issue: #92
this change adds a metric
keycloak_login_attempts
for the total number of login attempts. it might seem that it's possible to sum bothkeycloak_logins
andkeycloak_failed_login_attempts
but as thetotalLogins
andtotalFailedLoginAttempts
are counted separately their is now guarantee that both counters contain the same metrics (labels with same values). in order to make it possible to calculate the failure rate per instance a new countertotalLoginAttempts
is introduced.Checklist:
Progress
Screenshot