Added Input Validation tests and Imroved Modularity of code

aerogear / offix-android

Apollo GraphQL offline extensions for Android Platform

https://android.offix.dev

Apache License 2.0

37 stars 16 forks source link

Added Input Validation tests and Imroved Modularity of code #173

Open xatuke opened 4 years ago

xatuke commented 4 years ago

Description

Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.

Fixes #144

Type of Change:

Delete irrelevant options.

Code
Quality Assurance

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality)

GIF: 20191205_144844

How Has This Been Tested?

They Don't break the app, yet :)

Checklist

[x] tests are included

Lavanyagaur22 commented 4 years ago

@crowded-geek Good work! Keep it up 👍 Again not merging this because still some instances of the tasks are left. But I will surely do it after some time. Now you can actually work on issue no #170 because working on this issue will give you a pretty good idea of how the library is actually working. Task-related to it would soon be published and would be visible on your GCI dashboard. You can start working on this and claim the task after that. So that after you understand the library you can write the unit tests for it as well.

xatuke commented 4 years ago

@Lavanyagaur22 Okay, I'll work on #170 but before that I need to complete and submit some other tasks after them i'll do #170 :) Thanks ;)