search

aerogear / proposals

AeroGear Proposals
Apache License 2.0
0 stars 17 forks source link

proposal for shared services #13

Closed philbrookes closed 6 years ago

maleck13 commented 6 years ago

@philbrookes I think this is a good start, however I think we should also cover how a binding will work for a shared service. For instance, if you had a shared keycloak and then performed a binding against that serviceinstance that is pointing to a service in a different namespace. I don't think there will be too many difficulties but I think we should cover it in the proposal

maleck13 commented 6 years ago

In namespace A, metrics service (or maybe another service) is bound to KC in namespace C

@wei-lee I don't think this will happen. When provisioning the second KC it there will be a new serivceInstance created in namespace A that refers to the KC in namespace B. When asking for a binding within a namespace, it uses the service instance in that namespace as a reference. So it will be a binding to the keycloak that the serviceintance is associated with. In this case the one in namespace B.

@philbrookes I think we have to consider what may happen though if a developer deletes the serviceinstance in Namespace A, the deprovision playbook needs to be intelligent enough to only remove the realm and secrets / configmaps and not the the actual running KC instance

wei-lee commented 6 years ago

@maleck13 ah, right. Gotcha. There will still be a KC instance in the namespace A which should be used for binding by other services. But this instance maybe a pointer to a instance in another namespace. Is it right to say?

maleck13 commented 6 years ago

@wei-lee there will be a serviceinstance in namespace A yes that serviceinstance is "backed" by the KC in namespace B. Any bindings that happen in namespace A will be directed to KC in namespace B

maleck13 commented 6 years ago

Also needs to cover in detail how a deprovision on a shared service should behave. (spoke with Phil about this on a call). Proposal should cover how each action that can be performed against a regular instance will now work against a shared service

maleck13 commented 6 years ago

@david-martin you ok to give it another look over and approve if you are happy

david-martin commented 6 years ago

I'm happy with the changes after feedback :+1: Merging