search

aerogear / proposals

AeroGear Proposals
Apache License 2.0
0 stars 17 forks source link

Ui proposal #43

Closed pb82 closed 6 years ago

pb82 commented 6 years ago

Sync UI proposal. See TODO items for questions.

pb82 commented 6 years ago

ping @cfoskin

josemigallas commented 6 years ago

@pb82 Just a suggestion, it would be clearer having the screenshots attached and also faster.

josemigallas commented 6 years ago

@david-martin would it make sense to add some testing proposals as well? I would simply add unit and UI testing using jest.

david-martin commented 6 years ago

@david-martin would it make sense to add some testing proposals as well? I would simply add unit and UI testing using jest.

Adding testing to the proposal is OK if there's a clear idea what level of automated testing will be done at this stage. Automated testing of UI hasn't worked out well in the past on RHMAP (large overhead with test maintenance), but unit tests of the react/js code is a must IMO.

pb82 commented 6 years ago

@david-martin i'll add a few changes still and then merge