search

aerogearcatalog / metrics-apb

1 stars 23 forks source link

fix: create a ReadWriteMany PVC for Grafana #10

Closed darahayes closed 6 years ago

darahayes commented 6 years ago

Just a tiny thing I missed in https://github.com/aerogearcatalog/metrics-apb/pull/7

This is necessary to allow scaling of the Grafana pods

david-martin commented 6 years ago

@darahayes @wtrocki I'm a little late to this PR before it was merged. Apologies. I'd like to give any tagged reviewers the chance to give their review & lgtm/+1 before merging.

Was scaling tested with this change? Were there any issues with multiple Grafanas running from the 1 shared volume?

I'd like to get @psturc thoughts on impact of supporting scaling of Grafana and if its something we would add an automated test for, or a manual test at release time

psturc commented 6 years ago

Test of scaling the application sounds good to me. We also had that special test case for 4.x