search

aerogearcatalog / metrics-apb

1 stars 23 forks source link

Use the same 'app' label for all Deployments in the APB #30

Open david-martin opened 6 years ago

david-martin commented 6 years ago

By setting the same 'app' label on all Deployments, it will group all of the metrics Deployments into a single 'Application' in the OpenShift Web Console.

Currently, there are multiple Application groups image

Suggesting aerogear-metrics as the app label value. Altenatively, there could be 2 application labels to group 'app metrics' and 'server metrics', however where would Grafana be then?

cc @StevenTobin @darahayes

StevenTobin commented 6 years ago

The keycloak APB groups keycloak and postgres under a Keycloak application so I think grouping everything under aerogear-metrics makes sense, and its going to keep the UI clean when there's a number of other services provisioned.

group

david-martin commented 6 years ago

@StevenTobin aerogear-metrics sound good to me

StevenTobin commented 6 years ago

PR here: https://github.com/aerogearcatalog/metrics-apb/pull/34