aerogearcatalog / sync-app-apb

Apache License 2.0
0 stars 3 forks source link

Aerogear 8267 #4

Closed secondsun closed 5 years ago

secondsun commented 5 years ago

What this does :

secondsun commented 5 years ago

This includes https://github.com/aerogearcatalog/sync-app-apb/pull/3

wojta commented 5 years ago

@psturc Going to check this one, I had issues with multiple apps during checking my task, so I see if it fixes it.

psturc commented 5 years ago

From apb test (I had to check manually in OpenShift, because docker logs -f command used in Jenkins doesn't catch that apb container running before it dies, so it gets no logs):


TASK [create project for namespace] ********************************************
--
  | ok: [localhost]
  |  
  | TASK [include_role : provision-sync-app-apb] ***********************************
  |  
  | TASK [provision-sync-app-apb : Create sync-app deployment config] **************
  | fatal: [localhost]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'SYNC_APP_NAME' is undefined\n\nThe error appears to have been in '/opt/ansible/roles/provision-sync-app-apb/tasks/main.yml': line 1, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Create sync-app deployment config\n  ^ here\n"}
secondsun commented 5 years ago

@psturc Thanks. I was going to ask about the failure before the review :)