aerogearcatalog / unifiedpush-apb

Apache License 2.0
6 stars 21 forks source link

[AEROGEAR-2374] Remove labeling task and add label to the secret instead #30

Closed JameelB closed 6 years ago

JameelB commented 6 years ago

Description

Add the serviceInstanceID label in the secret created during provision and remove the labeling task from provision.

Progress

Verification Steps

Additional Notes

Related JIRA Ticket - https://issues.jboss.org/browse/AEROGEAR-2374

JameelB commented 6 years ago

@matzew rebased :)

psturc commented 6 years ago

Test won't pass because there's no service instance present when you run apb test, which means that _apb_service_instance_id variable is not defined: https://jenkins-wendy.ci.feedhenry.org/blue/organizations/jenkins/AeroGearCatalog%2Funifiedpush-apb/detail/PR-30/1/pipeline#step-51-log-75

@pb82 any idea how we could solve/workaround this?