search

aerogearcatalog / unifiedpush-apb

Apache License 2.0
6 stars 21 forks source link

fix: add bind parameter to specify production iOS cert #49

Closed darahayes closed 6 years ago

darahayes commented 6 years ago

Adds the following to the wizard for binding:

screen shot 2018-05-01 at 15 58 00

@pb82 @cfoskin For some reason I do not see our own secret after the bind. I am seeing this behaviour in the master image too. It's strange because the apb does not fail and the apb logs appear as if everything happened properly. Have you guys experienced this?

cfoskin commented 6 years ago

@darahayes What do you mean our own secret? I ran a binding on this branch there for iOS and it worked fine and created the variant and the secret also with the config.

darahayes commented 6 years ago

Thanks for the clarification @pb82 didn't realise it was being deleted purposefully. I thought I was going crazy!

@cfoskin just to clear things up, as you know the asb_encode_binding thing in the playbook will result in a secret being created. This is this pretty standard but in addition to this we are creating our own secret here. The secret definition is here.

If my understanding is correct, the reason we do this is because we need some labels on the secret (not possible with the default asb_encode_binding one) so the sidecar service can search for it and pick it up.

As @pb82 mentioned, this secret gets removed by the sidecar service once it sees it and creates the appropriate resources in UPS. I was confused about why I wasn't seeing the secret after the provision because I didn't realise it gets deleted 😄

cfoskin commented 6 years ago

@darahayes Yes I was not sure what secret you were talking about.