search

aerogearcatalog / unifiedpush-apb

Apache License 2.0
6 stars 21 forks source link

Bindings do not fail with invalid credentials #71

Open dimitraz opened 6 years ago

dimitraz commented 6 years ago

Description If the Android or iOS credentials passed in at the bind step are invalid, there is no validation and the binding does not fail. However it will not show up in the Mobile App's JSON config.

dimitraz commented 6 years ago

ping @pb82

pb82 commented 6 years ago

@dimitraz It's currently not possible to fail the binding as long is this issue on the ASB side is not resolved: https://github.com/openshift/ansible-service-broker/issues/941

The variant config does not show up because UPS itself will not create a variant when the parameters are invalid and the config operator will not annotate the mobile client when it doesn't get a variant from UPS.

Error handling was implemented in https://github.com/aerogearcatalog/unifiedpush-apb/pull/53 but had to be removed because of the issue linked above. Maybe it's worth retesting this with the latest ASB versions.