Better render footer, when copyright is set clear author message.

aerohub / hugo-orbit-theme

Great looking resume/CV theme designed for developers.

MIT License

253 stars 117 forks source link

Better render footer, when copyright is set clear author message. #1

Closed ryanfox1985 closed 7 years ago

aerohub commented 7 years ago

Hi, @ryanfox1985

What is the goal of these changes? They kill designer's copyright when copyright is set in config file, you know? :smile_cat:

ryanfox1985 commented 7 years ago

Hello @aerohub, yes I'm removing the author sentence when a copyright is set. I think that the resume is serious and I don't want a heard on the bottom. Anyway I keep the designer html comment. Regards.

aerohub commented 7 years ago

Well, @ryanfox1985 I think everyone who can use git and install Hugo knows many ways how to break designer's heart :smile: The theme was made for my training and used in official themes showcase as a demo of Hugo features. Nothing else. Let everyone who use it as a resume, solve the heart problem himself. I can't merge your PR but can keep it as an example how to do it in a good way.