aerokube / cm

Configuration manager for Aerokube products
https://aerokube.com/cm/latest/
Apache License 2.0
119 stars 31 forks source link

fix: split video args #289

Closed lxShaDoWxl closed 3 years ago

lxShaDoWxl commented 3 years ago

if usage cm selenoid start --vnc --tmpfs 128 --args "-video-recorder-image docker.io/selenoid/video-recorder:7.1" to arg video-recorder-image dublicate need usage cm selenoid start --vnc --tmpfs 128 --args "-video-recorder-image docker.io/selenoid/video-recorder:7.1 -video-output-dir /opt/selenoid/video/" this incorrect work

codecov[bot] commented 3 years ago

Codecov Report

Merging #289 (b3c4fb1) into master (a491e7c) will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   67.69%   67.75%   +0.06%     
==========================================
  Files           4        4              
  Lines        1040     1042       +2     
==========================================
+ Hits          704      706       +2     
  Misses        229      229              
  Partials      107      107              
Flag Coverage Δ
go 67.75% <100.00%> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
selenoid/docker.go 73.53% <100.00%> (+0.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 103d482...b3c4fb1. Read the comment docs.

vania-pooh commented 3 years ago

@lxShaDoWxl thank you for contribution!