aerokube / ggr

A lightweight load balancer used to create big Selenium clusters
https://aerokube.com/ggr/latest/
Apache License 2.0
314 stars 74 forks source link

added firstMatch support #352

Closed komorran closed 2 years ago

komorran commented 2 years ago

Hi, I've made some changes due to this issue - https://github.com/aerokube/ggr/issues/314 Changed data structure for capabilities in proxy.go, updated logic for firstMatch support and updated/implemented tests. Please let me know what I maybe should change or fix.

codecov[bot] commented 2 years ago

Codecov Report

Merging #352 (e23ebe7) into master (ad43f36) will increase coverage by 0.42%. The diff coverage is 98.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #352      +/-   ##
==========================================
+ Coverage   89.72%   90.15%   +0.42%     
==========================================
  Files           4        4              
  Lines         584      589       +5     
==========================================
+ Hits          524      531       +7     
+ Misses         47       46       -1     
+ Partials       13       12       -1     
Flag Coverage Δ
go 90.15% <98.41%> (+0.42%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
proxy.go 94.61% <98.41%> (+0.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35133a6...e23ebe7. Read the comment docs.

vania-pooh commented 2 years ago

@komorran sorry for the delay. We'll look into it as soon as possible.

vania-pooh commented 2 years ago

Fixed in #353. Thank you for contribution!