search

aerokube / images

Browser images for Selenoid and Moon 1.x
https://aerokube.com/images/latest/
Apache License 2.0
170 stars 127 forks source link

Add Safari 16 to images #576

Open Rendez opened 2 years ago

Rendez commented 2 years ago

The PR for Safari 15 is here, but 16 is so far missing. Can someone with more knowledge open a PR for this change?

Thanks community!

vania-pooh commented 2 years ago

@Rendez what is exact WebKit version you consider corresponding to Safari 16?

Rendez commented 2 years ago

That is the golden question, I am trying to figure it out, but it isn't specified yet: https://en.wikipedia.org/wiki/Safari_version_history#cite_note-117

Rendez commented 2 years ago

Ok, so I found a resource: https://tauri.app/v1/references/webview-versions/#webkit-versions-in-safari, and I double-checked this along my Safari.app -> XPCServices/com.apple.WebKit.WebContent.Safari.xpc/Contents/version.plist

<key>CFBundleVersion</key>
<string>17614.1.25.9.10</string>

Note the 614.1.25.9.10 which seems to be the webkit version, which also is greater than Safari 15 by a couple of major versions, just like it happens between jumps in Safari versions according to that Wikipedia article.

My Safari on the latest Monterey (12.6) at the time of this comment is Version 16.0 (17614.1.25.9.10, 17614)

Rendez commented 2 years ago

For building the docker image I see the build-arg $WEBKIT_TAG, but I'm not sure which branch from the webkit repo to pick, e.g.: https://github.com/WebKit/WebKit/tree/safari-7614.1.21-branch

Rendez commented 2 years ago

@vania-pooh does this require something else than modifying the .adoc?

vania-pooh commented 2 years ago

@Rendez this requires building respective image. :)

Rendez commented 2 years ago

I tried creating the docker image so far without luck, any hints?

vania-pooh commented 2 years ago

@Rendez we are investigating this stuff.