aerokube / images

Browser images for Selenoid and Moon 1.x
https://aerokube.com/images/latest/
Apache License 2.0
168 stars 126 forks source link

Removed ioutil #630

Closed vania-pooh closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (0670bf2) 5.88% compared to head (bfee8da) 5.88%.

:exclamation: Current head bfee8da differs from pull request most recent head 3e626b1. Consider uploading reports for the commit 3e626b1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #630 +/- ## ====================================== Coverage 5.88% 5.88% ====================================== Files 8 8 Lines 832 832 ====================================== Hits 49 49 Misses 776 776 Partials 7 7 ``` | Flag | Coverage Δ | | |---|---|---| | go | `5.88% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aerokube#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/aerokube/images/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aerokube) | Coverage Δ | | |---|---|---| | [build/base.go](https://app.codecov.io/gh/aerokube/images/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aerokube#diff-YnVpbGQvYmFzZS5nbw==) | `8.73% <0.00%> (ø)` | | | [build/file.go](https://app.codecov.io/gh/aerokube/images/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aerokube#diff-YnVpbGQvZmlsZS5nbw==) | `21.52% <0.00%> (ø)` | | | [build/firefox.go](https://app.codecov.io/gh/aerokube/images/pull/630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aerokube#diff-YnVpbGQvZmlyZWZveC5nbw==) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lionelnicolas commented 1 year ago

It looks like few references of ioutil have been forgotten here:

image

This prevent the build to succeed:

go: downloading github.com/aandryashin/matchers v0.0.0-20161126170413-435295ea180e
go: downloading github.com/mafredri/cdp v0.23.4
go: downloading github.com/gorilla/websocket v1.4.2
# github.com/aerokube/devtools [github.com/aerokube/devtools.test]
./devtools_test.go:178:13: undefined: ioutil
./devtools_test.go:183:2: undefined: ioutil
FAIL    github.com/aerokube/devtools [build failed]
vania-pooh commented 1 year ago

Fixed.

lionelnicolas commented 1 year ago

Fixed.

thanks