Open linjin-harvey opened 7 months ago
@linjin-harvey this is actually implemented, but this exact version 120.0.6099.216
is not present in their index file. https://github.com/aerokube/images/blob/master/build/chrome.go#L227
@vania-pooh The logic in https://github.com/aerokube/images/blob/master/build/chrome.go#L227 is correct, but even I tried existing version in https://[googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json](https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json) , like 120.0.6099.109, then the code https://github.com/aerokube/images/blob/master/build/chrome.go#L169 using below URL to download the chromedriver fails: https://chromedriver.storage.googleapis.com/120.0.6099.109/chromedriver_linux64.zip
COMMAND: ./images chrome -b https://dl.google.com/linux/deb/pool/main/g/google-chrome-stable/google-chrome-stable_120.0.6099.216-1_amd64.deb -d 120.0.6099.216 -t selenoid/chrome:120.0
ERROR:
ROOT CAUSE: Source code still using https://chromedriver.storage.googleapis.com/%s/chromedriver_linux64.zip to download all chromedriver version.![image](https://github.com/aerokube/images/assets/16532219/938887b7-01f3-417c-b9a4-bee9c28f3d3d)
SOLUTION: Change chromedriver download URL to https://edgedl.me.gvt1.com/edgedl/chrome/chrome-for-testing/%s/linux64/chromedriver-linux64.zip if download chromedriver version is >= 115