search

aerokube / images

Browser images for Selenoid and Moon 1.x
https://aerokube.com/images/latest/
Apache License 2.0
167 stars 125 forks source link

Video file has 0 Bytes when screen resolution has odd numbers #675

Open martingrossmann opened 6 months ago

martingrossmann commented 6 months ago

There seems to be an issue with the used MPEG encoder when the screen resolution of the browser container is set to a dimension with odd numbers like "1000x801" or "1001x800".

The browser container and VNC are not affected, just the generated video file has a size of 0 Bytes.

I know the workaround is simple and the normal desktop resolutions contains even numbers. But we found that using portrait resolutions to test responsive design. For example Chrome has some predefined resolutions in it's DevTools to simulate other (mobile) devices which contains odd numbers.

vania-pooh commented 6 months ago

@martingrossmann Having even resolution is a requirement of h264 codec we are using for encoding videos. So this is not a Selenoid limitation, but a ffmpeg codec limitation. This should have been fixed here: https://github.com/aerokube/images/pull/351

martingrossmann commented 6 months ago

Thank you for your answer. My image it too old...

martingrossmann commented 6 months ago

Ok, I doublechecked that... The latest Docker Hub image is sha256:b855ce71aeda6df96c8895cc9cabdb7e70275b2951e56b6b460439db0354ef18 and this was created 2020-12-06, some weeks before your fix. It seems Docker Hub needs an update?

vania-pooh commented 5 months ago

Yeah, probably need to rebuild from source.