aerokube / selenoid-ui

Graphical user interface for Selenoid project
https://aerokube.com/selenoid-ui/latest/
Apache License 2.0
305 stars 76 forks source link

feat: add two functions about copy and paste #494

Closed kaylezhangzhaoLin closed 1 year ago

kaylezhangzhaoLin commented 1 year ago
1. copy from selenoid clipboard to local
2. paste to selenoid from local clipboard
vania-pooh commented 1 year ago

@carl-pki could you please provide a screenshot how it looks like?

codecov[bot] commented 1 year ago

Codecov Report

Base: 31.42% // Head: 30.71% // Decreases project coverage by -0.70% :warning:

Coverage data is based on head (462bdd3) compared to base (1d2800d). Patch coverage: 4.16% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #494 +/- ## ========================================== - Coverage 31.42% 30.71% -0.71% ========================================== Files 38 38 Lines 732 752 +20 Branches 131 137 +6 ========================================== + Hits 230 231 +1 - Misses 441 458 +17 - Partials 61 63 +2 ``` | Flag | Coverage Δ | | |---|---|---| | go | `30.71% <4.16%> (-0.71%)` | :arrow_down: | | ui | `22.59% <4.16%> (-0.62%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aerokube#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/aerokube/selenoid-ui/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aerokube) | Coverage Δ | | |---|---|---| | [ui/src/components/VncCard/index.js](https://codecov.io/gh/aerokube/selenoid-ui/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aerokube#diff-dWkvc3JjL2NvbXBvbmVudHMvVm5jQ2FyZC9pbmRleC5qcw==) | `0.00% <0.00%> (ø)` | | | [ui/src/setupProxy.js](https://codecov.io/gh/aerokube/selenoid-ui/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aerokube#diff-dWkvc3JjL3NldHVwUHJveHkuanM=) | `0.00% <0.00%> (ø)` | | | [ui/src/components/VncCard/style.css.js](https://codecov.io/gh/aerokube/selenoid-ui/pull/494/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aerokube#diff-dWkvc3JjL2NvbXBvbmVudHMvVm5jQ2FyZC9zdHlsZS5jc3MuanM=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aerokube). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=aerokube)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kaylezhangzhaoLin commented 1 year ago

pleas tell me If you need any more information

vania-pooh commented 1 year ago

@carl-pki please attach a screenshot :)

kaylezhangzhaoLin commented 1 year ago

217f0efaa3606be5e0fe5c688075ebf 0916567cab78d7b14fc42785773025b

kaylezhangzhaoLin commented 1 year ago

I do not know how get service address, So I just support same address as Selenoid-UI and port must is 4444, If you have any suggestion please write down below. Thank you.

vania-pooh commented 1 year ago

@carl-pki is it possible to move these two buttons to the right and change color e.g. to pale yellow?

kaylezhangzhaoLin commented 1 year ago

what do you think ? image

vania-pooh commented 1 year ago

@carl-pki looks good for me. Let's wait for @lanwen to review the code itself.

vania-pooh commented 1 year ago

@carl-pki thank you for contribution!

kaylezhangzhaoLin commented 1 year ago

Hello, Ivan @.***>

at last pull request, I have a mistake. now I fix the bug, Can you help me to review the code? Sorry for my mistake.

https://github.com/aerokube/selenoid-ui/pull/497/files [https://avatars.githubusercontent.com/u/85552832?s=400&v=4]https://github.com/aerokube/selenoid-ui/pull/497/files Clipboard: fix a bug about 'copy from selenoid and paste to selenoid' by carl-pki ・ Pull Request #497 ・ aerokube/selenoid-uihttps://github.com/aerokube/selenoid-ui/pull/497/files description: Send the request to another container can not use ip=localhost, should use linked container name + port github.com


发件人: Ivan Krutov @.> 发送时间: 2022年10月10日 17:20 收件人: aerokube/selenoid-ui @.> 抄送: Zhang, Zhaolin @.>; Mention @.> 主题: [External] Re: [aerokube/selenoid-ui] feat: add two functions about copy and paste (PR #494)

@carl-pkihttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcarl-pki&data=05%7C01%7CZhaolin.Zhang%40PERKINELMER.COM%7C37366be8fadc4058baba08daaaa09c1d%7Cf9f27055d80d47dfabb2fa20cc88e4e1%7C0%7C0%7C638009904035961011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9UHdJJnW4w7EKqxf3XoeB8sc6%2Bc6UqW%2BivvkO3GI95g%3D&reserved=0 thank you for contribution!

― Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faerokube%2Fselenoid-ui%2Fpull%2F494%23issuecomment-1273023885&data=05%7C01%7CZhaolin.Zhang%40PERKINELMER.COM%7C37366be8fadc4058baba08daaaa09c1d%7Cf9f27055d80d47dfabb2fa20cc88e4e1%7C0%7C0%7C638009904035961011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3%2FCmZnRv0Sl%2BXgLnL7VRt%2BGSFASYCqzGEqWh12vSRIg%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUMW5QEO45RVQQXEH7TEH5DWCPNUDANCNFSM6AAAAAAQZPGH6E&data=05%7C01%7CZhaolin.Zhang%40PERKINELMER.COM%7C37366be8fadc4058baba08daaaa09c1d%7Cf9f27055d80d47dfabb2fa20cc88e4e1%7C0%7C0%7C638009904035961011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=QEGCaxz9WnQ4wB%2F2zD%2BVPZBdWlw9xoQ%2Fu%2Bq1VRSu3EI%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

kaylezhangzhaoLin commented 1 year ago

Hello, Ivan

      Thank you review last pull request. Can you rebuild a docker image to rewrite 1.10.6https://hub.docker.com/layers/aerokube/selenoid-ui/1.10.6/images/sha256-71d41080a2f6db0be170a3a548e64e05f3dc5ddf359cc75eb5e3e72700156d42?context=explore ? because the image have a bug. If you can not do it, can you build a docker image and use latest new code? We want to use copy and paste function easier than before. It doesn't matter if it can't.

                                                                                                                                                Tanks Ivan.


发件人: Zhang, Zhaolin @.> 发送时间: 2022年10月13日 17:01 收件人: aerokube/selenoid-ui @.> 主题: 回复: [External] Re: [aerokube/selenoid-ui] feat: add two functions about copy and paste (PR #494)

Hello, Ivan @.***>

at last pull request, I have a mistake. now I fix the bug, Can you help me to review the code? Sorry for my mistake.

https://github.com/aerokube/selenoid-ui/pull/497/files [https://avatars.githubusercontent.com/u/85552832?s=400&v=4]https://github.com/aerokube/selenoid-ui/pull/497/files Clipboard: fix a bug about 'copy from selenoid and paste to selenoid' by carl-pki · Pull Request #497 · aerokube/selenoid-uihttps://github.com/aerokube/selenoid-ui/pull/497/files description: Send the request to another container can not use ip=localhost, should use linked container name + port github.com


发件人: Ivan Krutov @.> 发送时间: 2022年10月10日 17:20 收件人: aerokube/selenoid-ui @.> 抄送: Zhang, Zhaolin @.>; Mention @.> 主题: [External] Re: [aerokube/selenoid-ui] feat: add two functions about copy and paste (PR #494)

@carl-pkihttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcarl-pki&data=05%7C01%7CZhaolin.Zhang%40PERKINELMER.COM%7C37366be8fadc4058baba08daaaa09c1d%7Cf9f27055d80d47dfabb2fa20cc88e4e1%7C0%7C0%7C638009904035961011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=9UHdJJnW4w7EKqxf3XoeB8sc6%2Bc6UqW%2BivvkO3GI95g%3D&reserved=0 thank you for contribution!

— Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faerokube%2Fselenoid-ui%2Fpull%2F494%23issuecomment-1273023885&data=05%7C01%7CZhaolin.Zhang%40PERKINELMER.COM%7C37366be8fadc4058baba08daaaa09c1d%7Cf9f27055d80d47dfabb2fa20cc88e4e1%7C0%7C0%7C638009904035961011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3%2FCmZnRv0Sl%2BXgLnL7VRt%2BGSFASYCqzGEqWh12vSRIg%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUMW5QEO45RVQQXEH7TEH5DWCPNUDANCNFSM6AAAAAAQZPGH6E&data=05%7C01%7CZhaolin.Zhang%40PERKINELMER.COM%7C37366be8fadc4058baba08daaaa09c1d%7Cf9f27055d80d47dfabb2fa20cc88e4e1%7C0%7C0%7C638009904035961011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=QEGCaxz9WnQ4wB%2F2zD%2BVPZBdWlw9xoQ%2Fu%2Bq1VRSu3EI%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

vania-pooh commented 1 year ago

@carl-pki done. Rebuilt 1.10.6.