Closed kaylezhangzhaoLin closed 1 year ago
@carl-pki could you please provide a screenshot how it looks like?
Base: 31.42% // Head: 30.71% // Decreases project coverage by -0.70%
:warning:
Coverage data is based on head (
462bdd3
) compared to base (1d2800d
). Patch coverage: 4.16% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
pleas tell me If you need any more information
@carl-pki please attach a screenshot :)
I do not know how get service address, So I just support same address as Selenoid-UI and port must is 4444, If you have any suggestion please write down below. Thank you.
@carl-pki is it possible to move these two buttons to the right and change color e.g. to pale yellow?
what do you think ?
@carl-pki looks good for me. Let's wait for @lanwen to review the code itself.
@carl-pki thank you for contribution!
Hello, Ivan @.***>
at last pull request, I have a mistake. now I fix the bug, Can you help me to review the code? Sorry for my mistake.
https://github.com/aerokube/selenoid-ui/pull/497/files [https://avatars.githubusercontent.com/u/85552832?s=400&v=4]https://github.com/aerokube/selenoid-ui/pull/497/files Clipboard: fix a bug about 'copy from selenoid and paste to selenoid' by carl-pki ・ Pull Request #497 ・ aerokube/selenoid-uihttps://github.com/aerokube/selenoid-ui/pull/497/files description: Send the request to another container can not use ip=localhost, should use linked container name + port github.com
发件人: Ivan Krutov @.> 发送时间: 2022年10月10日 17:20 收件人: aerokube/selenoid-ui @.> 抄送: Zhang, Zhaolin @.>; Mention @.> 主题: [External] Re: [aerokube/selenoid-ui] feat: add two functions about copy and paste (PR #494)
― Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faerokube%2Fselenoid-ui%2Fpull%2F494%23issuecomment-1273023885&data=05%7C01%7CZhaolin.Zhang%40PERKINELMER.COM%7C37366be8fadc4058baba08daaaa09c1d%7Cf9f27055d80d47dfabb2fa20cc88e4e1%7C0%7C0%7C638009904035961011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3%2FCmZnRv0Sl%2BXgLnL7VRt%2BGSFASYCqzGEqWh12vSRIg%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUMW5QEO45RVQQXEH7TEH5DWCPNUDANCNFSM6AAAAAAQZPGH6E&data=05%7C01%7CZhaolin.Zhang%40PERKINELMER.COM%7C37366be8fadc4058baba08daaaa09c1d%7Cf9f27055d80d47dfabb2fa20cc88e4e1%7C0%7C0%7C638009904035961011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=QEGCaxz9WnQ4wB%2F2zD%2BVPZBdWlw9xoQ%2Fu%2Bq1VRSu3EI%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>
Hello, Ivan
Thank you review last pull request. Can you rebuild a docker image to rewrite 1.10.6https://hub.docker.com/layers/aerokube/selenoid-ui/1.10.6/images/sha256-71d41080a2f6db0be170a3a548e64e05f3dc5ddf359cc75eb5e3e72700156d42?context=explore ? because the image have a bug. If you can not do it, can you build a docker image and use latest new code? We want to use copy and paste function easier than before. It doesn't matter if it can't.
Tanks Ivan.
发件人: Zhang, Zhaolin @.> 发送时间: 2022年10月13日 17:01 收件人: aerokube/selenoid-ui @.> 主题: 回复: [External] Re: [aerokube/selenoid-ui] feat: add two functions about copy and paste (PR #494)
Hello, Ivan @.***>
at last pull request, I have a mistake. now I fix the bug, Can you help me to review the code? Sorry for my mistake.
https://github.com/aerokube/selenoid-ui/pull/497/files [https://avatars.githubusercontent.com/u/85552832?s=400&v=4]https://github.com/aerokube/selenoid-ui/pull/497/files Clipboard: fix a bug about 'copy from selenoid and paste to selenoid' by carl-pki · Pull Request #497 · aerokube/selenoid-uihttps://github.com/aerokube/selenoid-ui/pull/497/files description: Send the request to another container can not use ip=localhost, should use linked container name + port github.com
发件人: Ivan Krutov @.> 发送时间: 2022年10月10日 17:20 收件人: aerokube/selenoid-ui @.> 抄送: Zhang, Zhaolin @.>; Mention @.> 主题: [External] Re: [aerokube/selenoid-ui] feat: add two functions about copy and paste (PR #494)
— Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faerokube%2Fselenoid-ui%2Fpull%2F494%23issuecomment-1273023885&data=05%7C01%7CZhaolin.Zhang%40PERKINELMER.COM%7C37366be8fadc4058baba08daaaa09c1d%7Cf9f27055d80d47dfabb2fa20cc88e4e1%7C0%7C0%7C638009904035961011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3%2FCmZnRv0Sl%2BXgLnL7VRt%2BGSFASYCqzGEqWh12vSRIg%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUMW5QEO45RVQQXEH7TEH5DWCPNUDANCNFSM6AAAAAAQZPGH6E&data=05%7C01%7CZhaolin.Zhang%40PERKINELMER.COM%7C37366be8fadc4058baba08daaaa09c1d%7Cf9f27055d80d47dfabb2fa20cc88e4e1%7C0%7C0%7C638009904035961011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=QEGCaxz9WnQ4wB%2F2zD%2BVPZBdWlw9xoQ%2Fu%2Bq1VRSu3EI%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>
@carl-pki done. Rebuilt 1.10.6.