search

aerokube / selenoid

Selenium Hub successor running browsers within containers. Scalable, immutable, self hosted Selenium-Grid on any platform with single binary.
https://aerokube.com/selenoid/latest/
Apache License 2.0
2.61k stars 324 forks source link

Document CPU and memory limits in browsers.json #1253

Open sporetec opened 3 years ago

sporetec commented 3 years ago

When creating a browsers.json file with cm there is no possibility to add a limit into the config. As I've found it's only possible to actually add the limit to the selenoid start command. We do however use this to create the config for moon and would love to not have our own extra script running to add a limit to each browser section.

aandryashin commented 3 years ago

Limit can be configured only via command line options.

вт, 31 авг. 2021 г., 12:59 Florian Mautendorfer @.***>:

When creating a browsers.json file with cm there is no possibility to add a limit into the config. As I've found it's only possible to actually add the limit to the selenoid start command. We do however use this to create the config for moon and would love to not have our own extra script running to add a limit to each browser section.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aerokube/selenoid/issues/1253, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKY23ISDWERCL5JB4SSW7LT7SRYLANCNFSM5DDXW2YQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

sporetec commented 3 years ago

But I can add a limit to the json manually, so why not implement it into the config creation?

aandryashin commented 3 years ago

You can, but it will no affect, it will be simple skipped. Again, limit can be configured only via command line option -limit.

вт, 31 авг. 2021 г., 14:58 Florian Mautendorfer @.***>:

But I can add a limit to the json manually, so why not implement it into the config creation?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aerokube/selenoid/issues/1253, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKY23M2QCGIP6HCKANF5ZLT7S7W7ANCNFSM5DDXW2YQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

sporetec commented 3 years ago

But why is it then specifially listed as working here: https://aerokube.com/moon/latest/#_browsers_list ?

aandryashin commented 3 years ago

Are you talking about cm? Cm is not related to moon, it can control only selenoid. Moon has helm based deployment and all configuration options can be set via helm values, please check:

https://github.com/aerokube/charts

вт, 31 авг. 2021 г., 15:05 Florian Mautendorfer @.***>:

But why is it then specifially listed as working here: https://aerokube.com/moon/latest/#_browsers_list ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/aerokube/selenoid/issues/1253, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKY23M7LIKS5FAT7UCVMRLT7TARBANCNFSM5DDXW2YQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

vania-pooh commented 3 years ago

@florianmautendorfer and even Moon has no such feature of controlling overall limit per browser version.

sporetec commented 3 years ago

That is fine with me, but then please update the documentation mentioned above as it clearly has limits and requests in the browser versions!

vania-pooh commented 3 years ago

@florianmautendorfer these are memory and CPU requests and limits and they are supported. What you are requesting is maximum browsers limit which is not supported.

sporetec commented 3 years ago

This is what I meant, sorry for the confusion! I did not find any info on how to add this to my configfile through cm.