search

aerokube / windows-images

Step by step instructions for building Docker images with Windows
Apache License 2.0
221 stars 44 forks source link

Create the docker image without the windows files #15

Closed emilorol closed 4 years ago

emilorol commented 4 years ago

I understand that reasoning of not providing a docker image with the windows files, but can you provide a docker image where the windows files have to be mounted?

By having a "windowless" docker image the user will still be responsible of providing the licenses, am I wrong or is this an slippery slop that can get you into trouble?

vania-pooh commented 4 years ago

@emilorol we are not sure whether we can push a copy of Windows to Docker Hub according to license terms.

emilorol commented 4 years ago

@vania-pooh I don't mean to push a copy of windows, but an "empty" container expecting the windows image file to be mapped to a volume path and run it from there.

I did an attempt myself here: https://hub.docker.com/r/emilorol/vnc_qemu

That image is expecting the windows image to be mounted to /images/ directory in order to run. I updated the entrypoint.sh script to support this.

vania-pooh commented 4 years ago

Summon @aandryashin

aandryashin commented 4 years ago

Such image will only contain entrypoint.sh... anyway we will think aboit such approach...

пт, 20 сент. 2019 г., 8:31 Ivan Krutov notifications@github.com:

Summon @aandryashin https://github.com/aandryashin

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aerokube/windows-images/issues/15?email_source=notifications&email_token=AAKY23KFTNLZLVTBFHH5YILQKRN4RA5CNFSM4IYOTEBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7FTR7Y#issuecomment-533412095, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKY23MNEL4HGO2BBLXH7LTQKRN4RANCNFSM4IYOTEBA .

emilorol commented 4 years ago

The main reasoning is that right after you finish figthing Windows VM to have it as you need it, you then need to build a new docker image and put it somewhere. If there is already an image build that will consume your Windows VM that will be make life a lot better.

aandryashin commented 4 years ago

Actually if you mount snapshot as volume lt will be persistent and you will not able back to initial state.

пт, 20 сент. 2019 г., 16:40 Emil Orol notifications@github.com:

The main reasoning is that right after you finish figthing Windows VM to have it as you need it, you then need to build a new docker image and put it somewhere. If there is already an image build that will consume your Windows VM that will be make life a lot better.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aerokube/windows-images/issues/15?email_source=notifications&email_token=AAKY23LL65OZHL3GFYQNUYDQKTHGTA5CNFSM4IYOTEBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7GXIXQ#issuecomment-533558366, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKY23NHUCXVSOVZ45BVZMTQKTHGTANCNFSM4IYOTEBA .

emilorol commented 4 years ago

I am not sure if I understand what you are saying, but is it to have the windows snapshot as part of the docker image as sharing it (windows snapshot) with other containers will not work.

Did I get it right?

aandryashin commented 4 years ago

Yes, snapshot part of image is mutable and should be isolated from others and should be packed to container. The only thing that can be shared is snapshot's backend image... But snapshot is individual for it's backend image. That is why we cannot build image without any part of windows. But you can build your own image without hdd.img and mount it from filesystem...

пт, 20 сент. 2019 г., 19:13 Emil Orol notifications@github.com:

I am not sure if I understand what you are saying, but is it to have the windows snapshot as part of the docker image as sharing it (windows snapshot) with other containers will not work.

Did I get it right?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aerokube/windows-images/issues/15?email_source=notifications&email_token=AAKY23P63YROBB7W72X4TADQKTZBDA5CNFSM4IYOTEBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7HF4FA#issuecomment-533618196, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKY23M6R7X7WQODOSBNDETQKTZBDANCNFSM4IYOTEBA .

emilorol commented 4 years ago

Ok, thank you for the clarification. Keep up the good work.

Related: https://github.com/aerokube/moon/issues/158