search

aerospaceresearch / orbitdeterminator

determination of satellite orbits and more
MIT License
181 stars 112 forks source link

one central place for orbital calculations #241

Open hornig opened 3 years ago

hornig commented 3 years ago

Hi,

during the years, the code grew with several places for almost the same calculations.

just two examples: https://github.com/aerospaceresearch/orbitdeterminator/blob/master/orbitdeterminator/kep_determination/gauss_method.py#L100-L135 https://github.com/aerospaceresearch/orbitdeterminator/blob/master/orbitdeterminator/kep_determination/gauss_method.py#L552-L640 and https://github.com/aerospaceresearch/orbitdeterminator/blob/master/orbitdeterminator/kep_determination/orbital_elements.py

maybe there are even more.

it is time to clean that up a bit, make them more universal, and find a better place for it.

so the tasks are: identify the different duplicates. find a better, central location implement an universal approach (by calling them, by naming convention and more. testing them that they keep the expected results.

Mohitvilasgiri commented 3 years ago

Respected sir, My name is Mohit Giri, a 3rd-year student studying Electronics and Telecommunication Engineering from St. Vincent Palloti College of Engineering and Technology. I am familiar with python I want to contribute to this project to increase my knowledge and improve my skills.

KingShark1 commented 3 years ago

going to take up this issue! @hornig would you assign this one?

hornig commented 3 years ago

going to take up this issue! @hornig would you assign this one?

hey @KingShark1 you can just start on this. why assigning? you also wanted to tackle other ones and then we waited on you. I still wait :).